Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576023

Hans de Goede <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #24 from Hans de Goede <[email protected]> 2010-07-19 10:28:53 
EDT ---
Hi,

(In reply to comment #23)
> spec: http://michael.cronenworth.com/RPMS/libwebcam.spec
> srpm:
> http://michael.cronenworth.com/RPMS/libwebcam-0.2.0-0.6.20100322svn.fc13.src.rpm
>     

Looks good now, one small nitpick left (which you can fix before import), there
is no need to separately list
%{_datadir}/uvcdynctrl/data/046d/logitech.xml

%{_datadir}/uvcdynctrl
Gets you everything below that dir. If you look at the build output of your
latest spec you will see the following there:

warning: File listed twice: /usr/share/uvcdynctrl/data/046d/logitech.xml


Approved!

Go create a FAS account if you have not already, request access to the
packagers group and let me know your FAS account name, then I'll sponsor you.

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to