Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226005

Thomas Spura <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected],
                   |                            |[email protected]
         AssignedTo|[email protected]    |[email protected]
               Flag|                            |fedora-review?

--- Comment #1 from Thomas Spura <[email protected]> 2010-07-19 
11:05:46 EDT ---
(CC'ing last modifiers)

Why do you use 'with_static' for deciding to build the static lib or not?

But even, when doing this, you need to package the static libs in a subpackage
called 'static' and do NOT place them in the usual devel subpackage...

Either delete that completely or properly package it in a static subpackage...


Other issues:
- Please use INSTALL="install -p" when installing to preserve timestamps
- https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
- There is a new version 1.0.2 upstream.
- libFS-devel.x86_64: E: useless-provides libFS-devel
  libFS.src:23: W: unversioned-explicit-provides %{name}-devel

The rest looks good so far.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to