https://bugzilla.redhat.com/show_bug.cgi?id=1103555
Ralf Corsepius <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Ralf Corsepius <[email protected]> --- Some remarks: 1. IMO, this package is not properly licensed: # licensecheck -r . | grep UNKNOW ./src/math/sampling.cpp: *No copyright* UNKNOWN ./src/continuous_collision.cpp: *No copyright* UNKNOWN ./include/fcl/exception.h: *No copyright* UNKNOWN ./include/fcl/math/vec_nf.h: *No copyright* UNKNOWN ./include/fcl/math/sampling.h: *No copyright* UNKNOWN ./include/fcl/ccd/simplex.h: UNKNOWN ./include/fcl/ccd/support.h: UNKNOWN ./include/fcl/continuous_collision.h: *No copyright* UNKNOWN ./include/fcl/learning/classifier.h: *No copyright* UNKNOWN ./test/libsvm_classifier.h: *No copyright* UNKNOWN ./test/general_test.cpp: *No copyright* UNKNOWN ./test/libsvm/svm.cpp: *No copyright* UNKNOWN ./test/libsvm/svm.h: *No copyright* UNKNOWN ./test/test_fcl_utility.cpp: *No copyright* UNKNOWN ./test/test_fcl_simple.cpp: *No copyright* UNKNOWN 2. fcl.x86_64: E: invalid-soname /usr/lib64/libfcl.so libfcl.so Please ask upstream to implement a proper SONAME, or add one yourself. 3. This construct in your spec will fail with consecutive short-circuit builds %build mkdir build; cd build A common work-around is to use mkdir -p build; cd build 4. This is an anacronism: %install rm -rf $RPM_BUILD_ROOT The "rm" is not needed anymore with recent rpms (IIRC, >= RHEL6) I for one consider 1. and 2. to be MUSTFIXes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
