https://bugzilla.redhat.com/show_bug.cgi?id=1212157
Lubomir Rintel <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|[email protected] |[email protected] Flags| |fedora-review? --- Comment #3 from Lubomir Rintel <[email protected]> --- (In reply to Antti Järvinen from comment #2) > Ok, > > I here is a review. Packaging seems sane to me, also the program seems > to work as promised. Notes are about: > - how to express licensing of parson lib in spec > - the way how %{buildroot} is cleaned. > - should file COPYING be installed using %license instead of %doc > Generic: > [!]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: %clean present and starts with rm -rf %{buildroot} Well, cleaning the %{buildroot} is not necessary at all. Nor is the %clean section; they've been deprecated for some time and only make sense if the package builds for el5. Same applies for %defattr. > Provides > -------- > plotnetcfg: > bundled(parson) This needs a comment with a link to the exception ticket. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
