https://bugzilla.redhat.com/show_bug.cgi?id=1015868
Yajo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] | |m) | --- Comment #11 from Yajo <[email protected]> --- (In reply to Raphael Groner from comment #9) > * Please use consistently the provided macros, also for the upstream project > name. You can use the %{url} macro to shorten additional links. > %global project qutepart > … Done. > * As this package is related to python2, you should use also the respective > macros to avoid any confusion. Python2 is still the default but will change > in near future to Python3. What about use python3 today? If yes, please > adjust BuildRequires, too. Done. > %license LICENSE > * Please use the %license macro for the license text, see my correction > above. > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > > * Do you plan packages for EPEL or Fedora 20? If yes, that usage of %license > macro will be problematic and needs some tweaking. Please let me know if you > need further help. AFAIK it only applies when upstream does not provide a LICENSE file. This is not the case. BTW, the docs are contradictory. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text says: "These prefixes are not valid in Fedora: %license and %readme." > * Do you plan packages for EPEL or Fedora 20? If yes, that usage of %license > macro will be problematic and needs some tweaking. Please let me know if you > need further help. I'm not planning those packages, but if somebody asks for it, I could try for EPEL. F20 is too close to death. > I'll update the respective bug fields to keep this open as a review request, > see comment #7. Thank you very much. SPEC URL: https://build.opensuse.org/source/home:yajo:enki/python-qutepart/python-qutepart.spec?rev=c390ab9e845d91b99b1d74e76ac3fbf7 SRPM URL: http://download.opensuse.org/repositories/home:/yajo:/enki/RHEL_7/src/python-qutepart-2.2.0-6.1.src.rpm That one is for RHEL, but I think the SRPM will be the same. If not, I can put the URL to the Fedora one once OBS finises the job. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
