https://bugzilla.redhat.com/show_bug.cgi?id=1177550
Zuzana Svetlikova <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] --- Comment #2 from Zuzana Svetlikova <[email protected]> --- Several comments: - there's new upstream release - missing multiple BuildRequires for both dependencies and devDependencies - BuildRequires for dependencies shouldn't be inside conditional - missing %{?nodejs_find_provides_and_requires} macro - different URL listed on npmjs (although it redirects, you should probably change it) - incompatible dependencies and devDependencies versions are fixed by %nodejs_fixdep macro (http://fedoraproject.org/wiki/User:Patches/PackagingDrafts/NodeJS#Correcting_Dependencies) - missing devDependencies aren't really blocking build since they're used for tests (plus stream-bench is also missing from repositories) - Summary should start with capital letter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
