https://bugzilla.redhat.com/show_bug.cgi?id=1224648
Miroslav Suchý <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Miroslav Suchý <[email protected]> --- Buildroot tag and relevant part in %clean is not needed unless you aim to RHEL5 https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Source0: https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz There is no tar.gz of this name on this URL. >%install >rm -rf $RPM_BUILD_ROOT Only needed for EL5. It can be safely removed for Fedoras and EL6+. It would be nice if you can consistenly use macros - $FOO vs %{foo}. I suggest to replace $RPM_BUILD_ROOT by %{buildroot} It would be nice if you can (as upstream) include LICENSE file (with %license macro). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
