https://bugzilla.redhat.com/show_bug.cgi?id=1226926
--- Comment #2 from Richard Shaw <[email protected]> --- I'm not familiar enough with eclipse to take this review but with a drive by spec review it looks pretty good. The only thing I see missing in the files section is a license file. Is one included in the source? If so the license macro should be used for f21+ (and I think epel7). If you plan to support older releases then you'll have to use a conditional. Something like: %if 0%{?rhel} || 0%{?fedora} < 21 %doc COPYING %else %license COPYING %endif And if epel7 does support the license macro then a "< 7" can be added to the rhel portion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
