https://bugzilla.redhat.com/show_bug.cgi?id=1223623

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
Fedoras <= 20 are EOL. %if 0%{?fedora} can be simplified to %if %{?fedora}.

There's no need to apply the license through a patch... Just put
Source1:
https://raw.githubusercontent.com/savoirfairelinux/num2words/master/COPYING
...
%license %{SOURCE1}
(Not tested)

Please fix the license tag. See comment #c4.

Hm, it's good to install tests, but they CANNOT be installed into a
non-namespaced directory: /usr/lib/python2.7/site-packages/tests. This should
be something like /usr/lib/python2.7/site-packages/num2words/tests. This is
basically an upstream error. It is actually better not to install tests than
install them here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to