https://bugzilla.redhat.com/show_bug.cgi?id=1227061
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- - BuildRoot and defattr can be removed [1] (unless you're packaging for EPEL5 too). - This is a preference thing, but the guidelines say that macros should be used *for directories* [2]. There's no specification to use e.g. %{__install} instead of install. I personally think that this makes reading the spec file much harder for not gain. - Note for the future: bash completion file should go in %{_datadir}/bash-completion/completions/, not in /etc/bash_completions.d. The latter is a legacy location. Requires -------- pcp2pdf (rpmlib, GLIBC filtered): /usr/bin/python /usr/bin/python3 config(pcp2pdf) The dependency on python looks wrong. Maybe there's a file header with #!/usr/bin/python somewhere? pcp2pdf.noarch: E: description-line-too-long C Utility to creates PDF reports from Performance Co-Pilot archives. It allows to choose Also "s" in "creates" is unnecessary. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Macros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
