https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Shawn Iwinski <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Shawn Iwinski <[email protected]> ---
* Shouldn't source come from https://github.com/wikimedia/oojs-ui as that's
where Composer installs from? -- https://packagist.org/packages/oojs/oojs-ui

* Per https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme, name should
be "php-oojs-oojs-ui"

* Per https://fedoraproject.org/wiki/Packaging:PHP#File_Placement, install path
should be "/usr/share/php/OOUI/*" to be PSR-0 compliant

* Per
https://fedoraproject.org/wiki/Packaging:PHP#Composer_registered_Packages, need
to provide "php-composer(oojs/oojs-ui) = %{version}"

* Tests are provided so they should be run in %check

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to