Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #2 from Kevin Fenzi <[email protected]> 2010-07-24 16:08:39 EDT --- Some general comments before doing a full review here: - You probibly want a dist tag. If you don't have one it becomes difficult to ship the same version to multiple release branches. - You should get rid of the "[ "$RPM_BUILD_ROOT" != "/" ] && " constructs. - You should get rid of the Vendor tag Fix those up and I can do the full review. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
