https://bugzilla.redhat.com/show_bug.cgi?id=1236319
--- Comment #10 from Ville Skyttä <[email protected]> --- 1) Requires: lz4 is still there, for no reason I can think of...? 2) Bundled code should be removed in %prep in order to make sure it doesn't get used (in this case at least some of it does get used, the private lz4.h ends up in -debuginfo). rm src/lz4*.[ch] early enough in %prep cures that. 3) Non-blocker: I think it would be cleaner to use libraries=["lz4"] instead of extra_link_args=["-llz4"]. 4) Cosmetic: the -O3 comment lines could be removed from %prep. Other than that, looks fine to me. Address at least 1) and 2) and you can set the review status to + yourself and proceed with importing, or let me know if you want further comments from me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
