https://bugzilla.redhat.com/show_bug.cgi?id=1236300



--- Comment #4 from Björn "besser82" Esser <[email protected]> ---
(In reply to Christian Dersch from comment #2)
> First run done, there are some things todo:
> 1.) Code contains GPLv3+ files, so the whole license has to be GPLv3+
> 2.) Please check if you need mozilla-filesystem as a requirement
> 3.) Inform upstream about missing license file

%changelog
  * Sun Jun 28 2015 Björn Esser <[email protected]> - 0.3.26-0.2
    - fixed License-tag
    - add Requires: mozilla-filesystem
    - informed upstream about missing full license-text and
      added a template for including the file into the package
    - add Patch0: adding configure-option to opt-out upstream's
      optimization flags


(In reply to Christian Dersch from comment #3)
> Why 0.1 in release tag? Is an official upstream release, so I would prefer 1

Will bump release to 1 after review on initial build.


Urls:

  Spec URL: https://besser82.fedorapeople.org/review/GarminPlugin.spec
  SRPM URL:
https://besser82.fedorapeople.org/review/GarminPlugin-0.3.26-0.2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to