https://bugzilla.redhat.com/show_bug.cgi?id=1209446
Parag AN(पराग) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #2 from Parag AN(पराग) <[email protected]> --- Review: + Package built successfully in mock F23 (x86_64) + rpmlint on all generated rpms gave output carbonate.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure carbonate.noarch: W: no-manual-page-for-binary carbon-sieve carbonate.noarch: W: no-manual-page-for-binary carbon-path carbonate.noarch: W: no-manual-page-for-binary carbon-hosts carbonate.noarch: W: no-manual-page-for-binary carbon-lookup carbonate.noarch: W: no-manual-page-for-binary carbon-sync carbonate.noarch: W: no-manual-page-for-binary carbon-list carbonate.noarch: W: no-manual-page-for-binary whisper-aggregate carbonate.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure 2 packages and 0 specfiles checked; 0 errors, 9 warnings. + Source verified with upstream as (sha256sum) source in srpm:fe9e0c1a1d806edf996fccb6ed5ca387fb0d50bfa14babdffa2bbbeaf003bc6a source upstream:fe9e0c1a1d806edf996fccb6ed5ca387fb0d50bfa14babdffa2bbbeaf003bc6a + License "MIT" is valid and included in its own text file LICENSE. + Follows python packaging guidelines Suggestions: 1) You don't need to package MANIFEST.in 2) As explained in https://fedoraproject.org/wiki/Packaging:Guidelines#Macros , system binaries mkdir should be used actually. so use "mkdir -p" instead %{__mkdir_p} rest looks fine. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
