https://bugzilla.redhat.com/show_bug.cgi?id=1216279



--- Comment #6 from Dave Johansen <[email protected]> ---
(In reply to Antonio Trande from comment #5)
> These two commands don't work:
> 
> + grep '^License' -A 25 /builddir/rpmbuild/BUILD/cppformat-1.1.0/README.rst
> + tail -n 21
> grep: /builddir/rpmbuild/BUILD/cppformat-1.1.0/README.rst: No such file or
> directory
> 
> README.rst is not found; try
> 
> grep "^License" -A 25 README.rst | tail -n 21 > LICENSE

Sorry, copy and paste error that I missed there. It's fixed now.

> + find -name '*.ttf' -delete
> 
> Are you sure it's sufficient remove it? Once done, is html documentation
> correctly displayable?

It appears that it would display but not with the correct font. It looks like
there's a bit of a mixed opinion, but just leaving the font is acceptable and
done by several existing packages:
https://lists.fedoraproject.org/pipermail/devel/2015-July/212293.html

> 2)
> -doc subpackage is a noarch package.

Fixed arch for -doc.

> 3)
> -doc subpackage does not provide its own LICENSE.python file.

Added LICENSE.python to -doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to