https://bugzilla.redhat.com/show_bug.cgi?id=1244353
Marcin Haba <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Marcin Haba <[email protected]> --- Hello, It is informal review because I am not Fedora packages maintainer. Here are a few comments: 1) No Spec URL attached to this bugzilla request. Please past in new comment Spec and SRPM. 2) Source0 is not possible to download: http://download.osgeo.org/ossim/source/ossim-1.8.18-1/ossim-1.8.18-1.tar.gz ERROR 404: Not Found. 3) rpmlint on source package shows: ossim.spec:154: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 154) 4) In Spec is a couple of commented BuildRequires $ grep '^#BuildRequires' ossim.spec #BuildRequires: ant #BuildRequires: gdal-devel #BuildRequires: hdf-devel #BuildRequires: hdf5-devel #BuildRequires: java-devel #BuildRequires: minizip-devel #BuildRequires: OpenSceneGraph-devel #BuildRequires: podofo-devel #BuildRequires: qt4-devel #BuildRequires: swig If there not exist any special reason to include these commented requirements I think that better might be not provide these comments because they make the Spec obfuscated. 5) License files should not be handled in %doc macro but in %license macro. https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
