Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618638

Marcela Mašláňová <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #1 from Marcela Mašláňová <[email protected]> 2010-07-28 04:20:17 
EDT ---
- rpmlint checks return:

- package meets naming guidelines OK
- package meets packaging guidelines OK
- license (Artistic 2.0) OK, text in %doc, matches source OK
- spec file legible, in am. english OK
- source matches upstream bc1d60d004b8b4d6aa8c11f3c4ccbc5f OK
- package compiles on devel (x86) OK
http://koji.fedoraproject.org/koji/taskinfo?taskID=2355937
- no missing BR OK
- no unnecessary BR OK
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean ok OK
- macro use consistent OK
- code, not content OK
- no need for -docs OK
- nothing in %doc affects runtime OK
- no need for .desktop file  OK

Comments: 
Kwalitee tests don't have to run.
Patches should be sent to upstream, but I suppose your patch make this module
work with older releases in EPEL, so they won't be applied in upstream anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to