https://bugzilla.redhat.com/show_bug.cgi?id=1239273
Julien Enselme <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #22 from Julien Enselme <[email protected]> --- > As an aside, the indentation you've added for the %if'd stuff in %files is > very > unusual for spec files. I don't think it should be causing an issue with > rpmbuild, but it may confuse other tools people use, so I would encourage you > not to indent like that. I add them to try to improve readability. I discorver while working on another package that %patch doesn't work if indented. So I will remove the indentations before importing the SPEC into git. > Presumably at this point, other toml parsers in Fedora can now use this test > suite in their %check - it'd be nice to file bugs against any other toml > parsers asking them to enable such functionality. I will open them once toml-test is in stable. Thanks for the review. > thank you for letting me know about the review and participating @Jan, thank you for helping! New Package SCM Request ======================= Package Name: golang-github-BurntSushi-toml-test Short Description: Language agnostic test suite for TOML Upstream URL: https://github.com/BurntSushi/toml-test Owners: jujens Branches: f22 f23 f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
