Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=618761 --- Comment #6 from Jessica Jones <[email protected]> 2010-07-28 06:35:22 EDT --- (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > While the spec file is legible, it's supposed to be en_US > > > timeframe -> time frame, time-frame > > > > Is there some way to check this sort of thing (I am finding conflicting > > sources)? I copied the description from the website, which is in US > > English as > > far as I know. > > I rely on RPMlint on the whole, if you've an online US dictionary > contradicting > this don't worry too much. I have made the changes suggested by rpmlint, although I did not change 'pre'. I'm finding all of those suggestions are fine according to the online US dictionary, but nevermind. > > > file-not-utf8 (LICENSE, README) > > > > Do you want me to add that to the spec file? > > Yes, sorry if that wasn't clear. Okay, done. > > > It's worth running a recent rpmlint over all the files before submitting, > > > the > > > EL-5 rpmlint is rather out of date. > > > > It would be nice if the people.fedoraproject.org servers had the koji client > > and rpmlint (and rpmbuild for creating SRPMs) on them. I will have to spend > > some time setting up a VM so that I can use it to build otherwise. > > rpmbuild is a deliberate omission, and koji would require your ssh private > keys. Personally I think it would be useful to add rpmlint to the post build > scripts in koji... True. I forget that koji uses ssh keys and not kerberos. I have updated the spec file and SRPM on my people.fedoraproject space (so same URL as before). Please could you check again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
