https://bugzilla.redhat.com/show_bug.cgi?id=1246761



--- Comment #1 from Michael Schwendt (Fedora Packager Sponsors Group) 
<[email protected]> ---
> Name:           libqtelegram-ae
> Group:          Applications/System

If at all, the Group tag for runtime libraries has been "System
Environment/Libraries" for many years. Nowadays, the tag is optional:

  https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

So, since you don't add the tag to the -devel package, consider removing it
from the base package as well.


> # Source comes from the libqtelegram fork ( maintained ) 
> # [email protected]:Aseman-Land/libqtelegram-aseman-edition.git
> Source0:        %{name}-%{version}.tar.xz

If there is no URL here, what are the steps on how to check out the code and
reproduce the tarball?

  https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control


> %files 
> %doc LICENSE README

There is the special %license macro since early 2015:

  https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing
  -> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to