https://bugzilla.redhat.com/show_bug.cgi?id=1245640
--- Comment #3 from Till Hofmann <[email protected]> --- Your new solution for GitVersion.sh looks good! [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Could you link to upstream bugs and/or link to pull requests? Your last version already improved this a lot, but links in the Spec file to the upstream bugs/pull requests would be really helpful, especially if the fixes aren't Fedora-specific. non-blocking issue: msed/MsedHexDump.h has a misleading license header. licensecheck detects it as BSD-licensed, but the file does not actually contain any proper license header. It's only one line of code, so I guess it's a non-blocker, but it would be nice if this could be reported upstream such that they can fix the header. Other than that, the package looks good. I'll post a formal review after the issue above has been fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
