https://bugzilla.redhat.com/show_bug.cgi?id=1247795
--- Comment #6 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #4) > 1. Please drop Requires: glibc >= 2.2.4-18 (EL-5 has glibc-2.5) and reformat > the rest of the (Build)Requires one per-line and sort alphabetically. Done. I also dropped all Requires. They don't seem necessary. > 2. Please add a comment explaining this in %build: > sed -i -e '/^prelink_LDADD/s/$/ -lpthread/' src/Makefile.{am,in} This wasn't neceessary either, dropped. > 3. Please add -p to install commands: > install -D src/execstack %{buildroot}%{_bindir}/execstack > install -Dm0644 doc/execstack.8 %{buildroot}%{_mandir}/man8/execstack.8 Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
