https://bugzilla.redhat.com/show_bug.cgi?id=1249270
Remi Collet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Remi Collet <[email protected]> --- small notes Package name is not correct, nothing related to composer. Should be, according to Guildelines php-firephp-firephp-core (perhaps php-firephp-core is acceptable) No reason to install in /usr/share/php/Composer This lib doesn't comply to PSR-0, so installation should be in some unique directory. e.g. /usr/share/php/FirePHPCore should be ok As this library doesn't use namespace and is not PSR-0 compliant, the symfony autoloader can't be used (composer.json states "classmap", so you need a classmap autoloader, but as this is only 2 files, and fb.php defines functions outside class; and include FirePHP.class.php, you probably don't need any). Notice: source0 seems to comply with current Guildelines (which are mostly "do what you want"), but as I don't consider using the "tag" as a good idea, I will NOT do the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
