https://bugzilla.redhat.com/show_bug.cgi?id=1227972

Christopher Meng <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #4 from Christopher Meng <[email protected]> ---
1. Requires: SDL-devel%{?_isa} in -devel

2. It's better to put %post and %postun before %files, it's a common habit.

3. Drop all Group tags.

4. https://github.com/dulsi/SDL_mng/blob/master/README

You need to put your changes to ChangeLog or some other files.

5. Add BuildRequires of automake autoconf libtool, and regenerate configure
scripts in %build by autoreconf -fiv.

6. %description devel
This is a simple library to load mng animations as SDL surfaces.

No, you should use these below for -devel packages:

This package contains libraries and header files for
developing applications that use %{name}.

7. You should create a pkg-config file for this, most of SDL packages in Fedora
contain pkg-config file. But, again I said "should", you can add this in future
release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to