https://bugzilla.redhat.com/show_bug.cgi?id=1256255

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok
License is ok.
Description is ok
URL and Source0 are ok
All tests passed

FIX: Please add BR 'make'
Otherwise BRs are ok

$ rpm -qp --requires perl-DBIx-Class-OptimisticLocking-0.02-1.fc24.noarch.rpm |
sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Carp)
      1 perl(DBIx::Class) >= 0.08195
      1 perl(List::Util)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

Binary requires are Ok.

$ rpm -qp --provides perl-DBIx-Class-OptimisticLocking-0.02-1.fc24.noarch.rpm |
sort | uniq -c
      1 perl(DBIx::Class::OptimisticLocking) = 0.02
      1 perl-DBIx-Class-OptimisticLocking = 0.02-1.fc24

Binary provides are Ok.

$ rpmlint perl-DBIx-Class-OptimisticLocking*
perl-DBIx-Class-OptimisticLocking.noarch: E: incorrect-fsf-address
/usr/share/licenses/perl-DBIx-Class-OptimisticLocking/LICENSE
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

Rpmlint is almost ok
TODO: Please report the wrong address to upstream.


Please correct all 'FIX' issues and consider fixing 'TODO' items
Otherwise, the package looks good.

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to