https://bugzilla.redhat.com/show_bug.cgi?id=1258182
Bug ID: 1258182
Summary: Review Request: go-compilers - Go language compilers
for various architectures
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Spec URL:
https://jchaloup.fedorapeople.org/reviews/go-compilers/go-compilers.spec
SRPM URL:
https://jchaloup.fedorapeople.org/reviews/go-compilers/go-compilers-1-1.fc20.src.rpm
Description: Go language compilers for various architectures
Fedora Account System Username: jchaloup
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10883004
ppc-koji: http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2726462
s390-koji: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1939911
Notes:
- on architectures specified by golang_arches macro
go-compilers-golang-compiler providing compiler(golang) and
compiler(go-compiler) virtual macros and requires golang and go-srpm-macros
packages
- on architectures specified by gccgo_arches macro go-compilers-gcc-go-compiler
providing compiler(gcc-go) and compiler(go-compiler) virtual macros and
requires gcc-go and go-srpm-macros packages
- all golang packages will BuildRequire compiler(go-compiler) virtual provides
which based on an architectures installs golang or gcc-go (transparent to spec
file)
This package is primarily targeted for f22 and higher. Epel6 can be included as
well (not for secondary architectures).
Resulting spec file will contain the following two improvements:
1) Choice of the correct architecture (applied for main and unit-test):
ExclusiveArch: %{go_arches}
BuildRequires: compiler(go-compiler)
2) shorter %build and %check section (go-compilers packages provides shell
library with gobuild and gotest functions definition):
source %{go_compilers_lib}
gobuild -o bin/go-md2man %{import_path}
Packages go-compilers and go-srpm-macros are meant to work together.
go-srpm-macros provides only macros which are independent of a golang language
compiler. go-compilers just takes some macros and glues golang/gcc-go compiler
with them to provide unifying virtual provide for all architectures. At the
same time it defines gobuild and gotest functions which can be used again
transparent to a given architecture. Thus making spec file unware of used
compiler.
At the moment go-srpm-macros is in a minimal buildroot (installed as a runtime
dependency of redhat-rpm-config). Once it is removed from the minimal
buildroot, it will be installed as a dependency of go-compilers subpackage.
Thus it should be available when srpm is generated (via BuildRequires:
compiler(go-compiler) in a main package). This should be tested (via mock or in
copr at least).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review
