https://bugzilla.redhat.com/show_bug.cgi?id=1257329
Chandan Kumar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected], | |[email protected] Assignee|[email protected] |[email protected] Flags| |needinfo?([email protected] | |om) --- Comment #4 from Chandan Kumar <[email protected]> --- Hello, Thanks for submitting for package review. Below is my inline comments. [1.] "Group: System Environment/Base" is not required, Since this tag is optional, Please remove it, https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag [2.] Also include python-pbr and python-setuptools under requires. [3.] under files section, [3.1] replace %{python_sitelib}/ironic_python_agent* with %{python2_sitelib}/ironic_python_agent* [3.2]and also include %{python2_sitelib}/ironic_python_agent-%{version}-py?.?.egg-info in next line. [4.] Since doc folder is also present in source tarball, Please create a doc sub package. rest looks ok to me. Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
