https://bugzilla.redhat.com/show_bug.cgi?id=1245351
Ralf Corsepius <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Ralf Corsepius <[email protected]> --- Some remarks: - Please add appropriate %changelog entries to the spec. - %license is missing Please add: %license LICENSE - This %{_mandir}/man1/ps2emu-record.1.gz %{_mandir}/man1/ps2emu-replay.1.gz should be %{_mandir}/man1/ps2emu-record.1* %{_mandir}/man1/ps2emu-replay.1* - Building is non-verbose: ... CC ps2emu-record.o CC ps2emu-event.o ... This renders it impossible to check whether compilation receives the correct CFLAGS. Please append --disable-silent-rules to %configure - Please increment %release each time you change something on your package. This helps avoiding troubles and misunderstanding during reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
