https://bugzilla.redhat.com/show_bug.cgi?id=1258874
Jens Lody <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Jens Lody <[email protected]> --- This is an informal review: The LICENSE file must be included in %license, not %doc. The "License:"-tag must list all used licenses: ASL 2.0, BSD and GPLv2+, you should aadd a comment like: All files are licensed under ASL 2.0 except maxminddb-compat-util.h which is licensed under BDS (3 clause) and ltmain.sh which is licensed under GPLv2+. The Group tag is not neede (except for EPEL) and should normally be removed. The Source0-url does not work (gives 403 forbidden). First quick look, more to follow, (after work). jens -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
