https://bugzilla.redhat.com/show_bug.cgi?id=1255179
--- Comment #18 from Jan Chaloupka <[email protected]> --- > > > The package description should be more than just a copy of the summary. > > > > At the moment I don't see any description that would be explaining enough > > what runc is. If you have an idea what description is suitable, please. I > > will update the spec file accordingly. > > Possibly "The runc command can be used to start containers which are packaged > in accordance with the Open Container Initiative's specifications, and to > manage containers running under runc.", or something that includes more of the > details from the web site or runc's --help output. Updated. > > > [ ]: Spec use %global instead of %define unless justified. > > > Why is copying() defined using %define rather than %global? > > > > Because copying is a parametric macro which needs to be evaluated in the > > time of use. As a global, it would be evaluated in the time of definition > > end up with empty %license macro. > > Are you sure that's necessary here? When I try changing it, the files > show up in the right place with the right file flags in the binary packages. copying parametric macro completely removed. Replaced with: {!?_licensedir:%global license %doc} Spec URL: https://jchaloup.fedorapeople.org/reviews/runc/runc.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/runc/runc-0.2-0.2.git90e6d37.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
