https://bugzilla.redhat.com/show_bug.cgi?id=1243506



--- Comment #10 from Petr Ĺ abata <[email protected]> ---
* The license isn't just Beerware.  Everything under the lib/Net/HL7/ directory
is licensed under the usual `same as perl' terms.
  The correct License tag would be `Beerware and (GPL+ or Artistic)'.

* Some build deps are missing:
  - perl(base)
    + lib/Net/HL7/Daemon.pm:4
    + lib/Net/HL7/Daemon.pm:121
    + lib/Net/HL7/Messages/ACK.pm:17
    + lib/Net/HL7/Request.pm:14
    + lib/Net/HL7/Response.pm:14
    + lib/Net/HL7/Segments/MSH.pm:15
  - perl(Config)
    + t/daemon.t:36
    + t/message.t:6
  - perl(Errno)
    + lib/Net/HL7/Connection.pm:7
    + lib/Net/HL7/Daemon.pm:213
  - perl(IO::Socket)
    + lib/Net/HL7/Connection.pm:6
    + lib/Net/HL7/Daemon.pm:3
    + lib/Net/HL7/Daemon.pm:119
  - perl(IO::Socket::INET)
    + lib/Net/HL7/Daemon.pm:4
    + lib/Net/HL7/Daemon.pm:121
  - perl(POSIX)
    + lib/Net/HL7/Segments/MSH.pm:16
  - perl(Sys::Hostname)
    + lib/Net/HL7/Daemon.pm:91

* The Sys::Hostname dependency won't get autodetected by our generators.
  You need to require it explicitly.

* You should own the %{perl_vendorlib}/Net directory here, too.
  %{perl_vendorlib}/* is sufficient.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to