https://bugzilla.redhat.com/show_bug.cgi?id=1264656

Vít Ondruch <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #3 from Vít Ondruch <[email protected]> ---
Just a few quick points:

* What about test suite?
* How about bundling? This directory looks suspicious: %{gem_instdir}/vendor
* You list several BuildRequires which you definitely don't need ATM, since you
don't execute the test suite.
* We typically try to avoid build time dependency on Bundler as much as
possible. Not sure this will be the case, but its always worth asking.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to