https://bugzilla.redhat.com/show_bug.cgi?id=1268920

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please add BR perl(File::Temp) - 00-compile.t:11

$ rpm -qp --requires
perl-Dist-Zilla-App-Command-cover-1.101001-1.fc24.noarch.rpm | sort | uniq -c
      1 perl >= 0:5.008
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Dist::Zilla::App)
      1 perl(File::Temp)
      1 perl(File::chdir)
      1 perl(Path::Class)
      1 perl(strict)
      1 perl(warnings)
      1 perl-Devel-Cover
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

Binary requires are Ok.

$ rpm -qp --provides
perl-Dist-Zilla-App-Command-cover-1.101001-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(Dist::Zilla::App::Command::cover) = 1.101001
      1 perl-Dist-Zilla-App-Command-cover = 1.101001-1.fc24

Binary provides are Ok.

$ rpmlint perl-Dist-Zilla-App-Command-cover*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

Please correct 'FIX' issue.

Otherwise the package looks good.
APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to