https://bugzilla.redhat.com/show_bug.cgi?id=1269001
--- Comment #2 from Tom Hughes <[email protected]> --- Quite a few things here: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/pkgconfig Need to require pkgconfig, and in any case it should be lib64 for both this and the library on x86_64. [!]: %build honors applicable compiler flags or justifies otherwise. Need to get $RPM_OPT_FLAGS in there. [!]: Package consistently uses macros (instead of hard-coded directory names). Use %{_bindir}, %{_libdir} etc in file lists. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. MIT license requires text so we will need to add it locally until upstream do. [!]: %check is present and all tests pass. There are tests, any chance of running them? [!]: Spec file according to URL is the same as in SRPM. See fedora-review output. Also no version number in changelog header. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
