https://bugzilla.redhat.com/show_bug.cgi?id=1271768



--- Comment #2 from Haïkel Guémar <[email protected]> ---
Minor fixes:
* we need conditionals so that we can rebuild the package on EL7 where there's
no python3 (except EPEL70
%if 0%{?fedora}
%global with_python3
%endif

* defattr is not needed anymore

* rather than defining a shell variable to retrieve python2 short version.
%{!?python2_shortver: %global python2_shortver %(%{__python2} -c 'import sys;
print(str(sys.version_info.major) + "." + str(sys.version_info.minor))')}

* too large wildcards for stuff in site-packages directories, we need to
distinguish at least different directories so they are not unowned.

* could we ship python2 version of the command-line?
Here's a sample, how we do it according guidelines
http://mferminl.web.cern.ch/mferminl/fedorapkg/python-yaql/python-yaql.spec

%{_bindir}/shade-inventory-3
%{_bindir}/shade-inventory-%{python3_shortver}
%{_bindir}/shade-inventory-2
%{_bindir}/shade-inventory-%{python2_shortver}
%{_bindir}/shade-inventory (depending if we're on Fedora or EL7 symlinks to
either python2 or python3 version.

Except the points above, the package installs, works and is sane.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to