https://bugzilla.redhat.com/show_bug.cgi?id=1272248
--- Comment #6 from Luis Pabón <[email protected]> --- (In reply to Jan Chaloupka from comment #5) > Hi Luis, > > spec files looks fine. Just some nits: > - for license, %license tag can be used when redefining the tag explicitly > for el6. > - for %{gopath}/src/%{import_path} directory, it is better to include it in > devel.file-list file as the root directory could contain both source files > and tests file. Thus resulting in multiple ownership of the directory. > - when building heketi from bundled deps, it fails to build due to missing > heketi source codes > - when building with debuginfo, bundled build is missing BUILD_ID Hi Jan, Do you mind providing line numbers to the first two? Any suggestions on how to fix any of these issues are welcomed. I used gofed, then based the rest of my changes on etcd.spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
