https://bugzilla.redhat.com/show_bug.cgi?id=1272652
Richard Shaw <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Richard Shaw <[email protected]> --- Quick spec review first: 1. Location of Summary tag is weird but not a problem. 2. Group tags are not required 3. BuildRoot tag not required unless you want to support RHEL 5. 4. Automake builds are not usually verbose unless V=1 is added to the make command (more detail in the build logs is better) 5. rm -rf $RPM_BUILD_ROOT in %install not needed 6. %clean not required unless supporting RHEL 5 7. %{!?_licensedir:%global license %doc} -- Have you verified this works? I know it was a suggestion on the ticket but it was found not to work, I use: %if 0%{?rhel} < 7 || 0%{?fedora} < 21 %doc COPYING %else %license COPYING %endif 8. %defattr(-,root,root) not needed. 9. "%_mandir/mann/tkTable.*" -- Strange that mandir isn't in {} but I guess it works fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
