https://bugzilla.redhat.com/show_bug.cgi?id=1264546
--- Comment #28 from Michael Schwendt (Fedora Packager Sponsors Group) <[email protected]> --- > Do we make updates and changelog bumps here in process of > package review too (before any publishment)? Yes. It's only pointed out at https://fedoraproject.org/wiki/FrequentlyMadePackagingMistakes because for the review process it has been assumed that modifying a src.rpm implies changing the spec file and publishing the changes as a _new_ src.rpm release. Occasionally, during review somebody skips the Release bump, though, and that makes reviewing less convenient (with the tools from "rpm -ql rpmdevtools|grep diff" in mind, for example). > %{_includedir}/soletta/ > > The ending / will make it clear is is a directory (and contents). As explained in the guidelines, the trailing slash is purely cosmetic. The lines %{_includedir}/soletta and %{_includedir}/soletta/ achieve the same, regardless of whether "soletta" is a file or a directory tree. The trailing slash only increases readability of the spec file, making it explicit that the %files line doesn't refer to a single file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
