https://bugzilla.redhat.com/show_bug.cgi?id=1272187
Paul Howarth <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] --- Comment #1 from Paul Howarth <[email protected]> --- Some initial comments prior to a formal review: * Current upstream version is 1.4.2, not 1.4.1 * I'd suggest replicating the runtime Requires: as BuildRequires: That way, not only should any future test suite run OK, but you'll find out at build-time rather than install-time if there are any dependency issues. * Version requirements from setup.py are not reflected in rpm deps. * Dependency on python-six is missing. * Comment referring to BZ 1205170 can probably be dropped. * Shellbang removal should be done in %prep rather than %install; if done before the copy to %{py3dir}, it can be done just once. * Typo in comment for 1.4.0-1: pythn3 missing "o". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
