https://bugzilla.redhat.com/show_bug.cgi?id=1271829
Troy Dawson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #5 from Troy Dawson <[email protected]> --- Looks very good. I do have one comment. You switched from the npm package to the github tarball, which automatically brings in the tests and LICENSE. That's great. But, you forgot to remove the Source1 and Source10 that brought in the tests, along with the "%setup -q -T -D -a 1 -n package" in the %prep section. It would make things more clean if you removed the Source1, Source10 and the extra line in the %prep section. In the end, this doesn't matter, It's the same tests, and the tests now pass, so that is great. I'm going to approve it, but I would recommend removing them. Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
