https://bugzilla.redhat.com/show_bug.cgi?id=1277487



--- Comment #5 from Shawn Iwinski <[email protected]> ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.  Not a blocker.



[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "Unknown or generated", "GPL (v2 or later)
     (with incorrect FSF address)", "*No copyright* GPL (v2 or later)",
     "GPL (v2)", "*No copyright* Apache (v2.0)". 75 files have unknown
     license.

     Library is GPLv2+ not MIT.

     In tests there are also some Apache, BSD, GPL, and MIT licenced files
     though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to