Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621017 Mamoru Tasaka <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Mamoru Tasaka <[email protected]> 2010-08-05 15:41:33 EDT --- Some notes: * Unused macros - Defined %ruby_sitelib macro seems used nowhere * License ------------------------------------------------------------- CC-BY ./website/javascripts/lightbox.js LGPLv2+ ./website/javascripts/rounded_corners_lite.inc.js ------------------------------------------------------------- - License tag should be "MIT and CC-BY and LGPLv2+" (also see below) * Requires - "R: ruby(abi) = 1.8" is a must item. - "rubygem(hoe)" is for development dependency (for Rakefile) and is not needed for runtime (Also "hoe" is marked as "s.add_development_dependency" in installed .gemspec file) - lib/scruffy.rb contains: ------------------------------------------------------------ 17 require 'rubygems' 18 gem 'builder', '>= 2.0' 19 require 'builder' ------------------------------------------------------------ So this package should have "Requires: rubygem(builder)". * Documents - I guess the following files / directories can be moved to -doc subpackage (after creating -doc subpackage). Would you consider this? ---------------------------------------------------------- %{geminstdir}/Rakefile %{geminstdir}/config %{geminstdir}/script %{geminstdir}/spec %{geminstdir}/test %{geminstdir}/website %{geminstdir}/tasks %{geminstdir}/setup.rb %{gemdir}/doc/%{gemname}-%{version} ---------------------------------------------------------- * %check - As this gem contains spec/ and test/ directories, please add %check section and execute some test programs ($ rake test and $ rake spec) there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
