https://bugzilla.redhat.com/show_bug.cgi?id=1274996
Jared Smith <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Flags| |needinfo?([email protected] | |om) --- Comment #1 from Jared Smith <[email protected]> --- At first I didn't understand what you were doing in the %check section, untiL I realized that there were two more files needed for running the tests. I would do the following: 1) In the header, add the following lines: # The following two packages are needed for testing only Source1: https://github.com/rvagg/isstream/raw/master/readable-stream-1.0.26-4.tgz Source2: https://github.com/rvagg/isstream/raw/master/readable-stream-1.1.12-1.tgz 2) In the %setup section, add the following lines: cp -p %{SOURCE1} . cp -p %{SOURCE2} . 3) In the globals at the top of the file, re-enable the tests. I'll do the formal review once you've fixed up the tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
