https://bugzilla.redhat.com/show_bug.cgi?id=1267496
Toshio Ernie Kuratomi <a.bad...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |a.bad...@gmail.com
--- Comment #10 from Toshio Ernie Kuratomi <a.bad...@gmail.com> ---
A few notes:
* Since this package is now in the distribution, this review ticket can now be
closed.
* When packaging python2/python3 packages you need to be careful about your
dependencies. In https://bugzilla.redhat.com/show_bug.cgi?id=1267496#c7
fedora-review spit out the Requires for both subpackages. python3-reno
requires /usr/bin/python2 which is an indication that there's something wrong
with the package.
* When a package provides both python2 and python3 subpackages, you need to
take care of which interpreter the executable is using and in which subpackage
it is placed. I just committed this patch to rawhide:
http://pkgs.fedoraproject.org/cgit/python-reno.git/commit/ which fixes this
particular package.
For this package, the /usr/bin/reno script is not functionally different when
it runs under python2 or python3. So the packaging guidelines tell us that in
this case we should only ship one version of the script, running against
python3 (from fedora22 onward):
https://fedoraproject.org/wiki/Packaging:Python#Avoiding_collisions_between_the_python_2_and_python_3_stacks
Note: In a few packages running under python2 vs python3 does make a
difference. Many unittest frameworks, for instance, can only inspect python2
code if the executable is run under python2 and can only inspect python3 code
if it is run under python3. The guidelines specify a way to rename the
executable that's shipped in the python3 package to deal with those situations.
That's not the case here.
Thanks to both of you for packaging and reviewing. Hopefully this comment
gives you some information that you can use when packaging and reviewing future
python3 packages.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
