https://bugzilla.redhat.com/show_bug.cgi?id=1266805

Tom "spot" Callaway <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #1 from Tom "spot" Callaway <[email protected]> ---
Good:

- rpmlint checks return nothing.
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %license, matches source
- spec file legible, in am. english
- source matches upstream
(b219ac0fee6a3c35e8812d8ad5b13f1b700e0cf167414f54cf250fb29dc9d058)
- package compiles on f23 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- javadoc ok
- nothing in %doc affects runtime
- no need for .desktop file 

As always, a very good package gil. Nice work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to