https://bugzilla.redhat.com/show_bug.cgi?id=995433
Tom "spot" Callaway <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #3 from Tom "spot" Callaway <[email protected]> --- Good: - rpmlint checks return: glassfish-ejb-api.src: W: invalid-url Source0: glassfish-ejb-api-3.2.tar.xz glassfish-ejb-api.noarch: W: no-documentation All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (CDDL or GPLv2 with exceptions) OK, text in %license, matches source - spec file legible, in am. english - source matches upstream (manual check okay) - package compiles on f23 (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - javadoc okay - nothing in %doc affects runtime - no need for .desktop file One more time, the license tag should be "CDDL or GPLv2 with exceptions". Your spec says "and". Please fix before import. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
