https://bugzilla.redhat.com/show_bug.cgi?id=1280343



--- Comment #2 from Petr Ĺ abata <[email protected]> ---
* Since you chose the pkgconfig() approach, the build dependency on
  fribidi-devel seems rather pointless.

* Data::Dumper, and version are only used by the disabled t/ucd.t test.
  You can drop these build deps for now.

* I don't think the urxvt subpackage strictly requires the base package
  in this case and were it me, I would drop this dependency.
  If you decide to do this, don't forget to add the license text to the
  subpackage as well.

* The package doesn't build in mock.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to