https://bugzilla.redhat.com/show_bug.cgi?id=1200038



--- Comment #4 from Terje Røsten <[email protected]> ---
Some quick comments.

- BuildRoot: ..., %clean section, line %defattr(-,root,root,-) and line rm -rf
$RPM_BUILD_ROOT in %install are not needed, remove these

- Use %license macro

- Lines in %%description too long

- Drop disttag from changelog, use: 1.9-1 
  This way you can use same spec file for all branches.

- Add empty line between each changelog item.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to