https://bugzilla.redhat.com/show_bug.cgi?id=1284527
--- Comment #18 from Vasant Hegde <[email protected]> --- Dan, Thanks for the review. (In reply to Dan Horák from comment #16) > - distro-wide CFLAGS are not honoured in the build - > https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags Added "%{?_smp_mflags}" > - make the build of opal-prd verbose so the full command lines are visible > (add V=1) Fixed. > - you should drop the "$RPM_BUILD_DIR/skiboot-skiboot-%version/" string from > the make commands, it's the default dir for rpm builds (see build.log) Fixed. > - I think you don't need kernel-devel and playing with the KERNEL_DIR at > all, the asm/opal-prd.h file is part of the kernel-headers package which is > installed together with glibc-headers as it is a public API > (http://ppc.koji.fedoraproject.org/koji/fileinfo?rpmID=2562590&filename=/usr/ > include/asm/opal-prd.h) You are right. I will fix this. Also I've removed `kernel` from "Requires" tag as its installed by default. -Vasant -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
